-
-
Couldn't load subscription status.
- Fork 2.1k
[breaking] make sveltekit() return a promise
#7994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 31a5d04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, notwithstanding the conflict
In vite-plugin-svelte, it currently helps SvelteKit set the fallback hydrate value. This PR moves the logic into kit itself so we can remove the hardcoded logic.
Returning a promise is supported since Vite 3 so no peer dep bump is needed. In practice this shouldn't break most SvelteKit apps, unless someone is calling
sveltekit()programmatically and accessing the plugins individually.This will likely conflict with #7990
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0